netdev - Re: [PATCH] net: mlx5: vport: Add error handling in mlx5_query_nic_vport_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d64750d-e394-462f-8356-9571f1b70173@oracle.com>
Date: Mon, 19 May 2025 13:26:19 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Wentao Liang <vulab@...as.ac.cn>, saeedm@...dia.com, leon@...nel.org,
        tariqt@...dia.com, andrew+netdev@...n.ch, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] net: mlx5: vport: Add error handling in
 mlx5_query_nic_vport_node_guid()



On 19-05-2025 12:31, Wentao Liang wrote:
> The function mlx5_query_nic_vport_node_guid() calls the functuion

typo functuion

> mlx5_query_nic_vport_context() but does not check its return value.
> A proper implementation can be found in mlx5_nic_vport_query_local_lb().
> 
> Add error handling for mlx5_query_nic_vport_context(). If it fails, free
> the out buffer via kvfree() and return error code.
> 
> Fixes: 9efa75254593 ("net/mlx5_core: Introduce access functions to query vport RoCE fields")


Thanks,
Alok