netdev - Re: [PATCH v1 net] net: lan743x: Restore SGMII CTRL register on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <067713e1ebaf303fe4aefb9c29cc7e1b70cd722a.camel@microchip.com>
Date: Mon, 19 May 2025 09:23:56 +0000
From: <Thangaraj.S@...rochip.com>
To: <kuba@...nel.org>
CC: <andrew+netdev@...n.ch>, <Bryan.Whitehead@...rochip.com>,
	<davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH v1 net] net: lan743x: Restore SGMII CTRL register on
 resume

Hi Jakub,
On Fri, 2025-05-16 at 16:40 -0700, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Fri, 16 May 2025 09:27:19 +0530 Thangaraj Samynathan wrote:
> > SGMII_CTRL register, which specifies the active interface, was not
> > properly restored when resuming from suspend. This led to incorrect
> > interface selection after resume particularly in scenarios
> > involving
> > the FPGA.
> > 
> > To fix this:
> > - Move the SGMII_CTRL setup out of the probe function.
> > - Initialize the register in the hardware initialization helper
> > function,
> > which is called during both device initialization and resume.
> > 
> > This ensures the interface configuration is consistently restored
> > after
> > suspend/resume cycles.
> 
> Is there a reason you're not CCing Raju Lakkaraju on this?
> Having a review tag from the author of the change under Fixes
> is always great.
Thanks for pointing this out.
Raju Lakkaraju is no longer with the company, and as I am currentlymanaging this driver, I have not included him in the CC.

Thanks,
Thangaraj Samynathan