netdev - Re: [PATCH net-next v2 2/3] net: airoha: Add FLOW_CLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250519094637.GE365796@horms.kernel.org>
Date: Mon, 19 May 2025 10:46:37 +0100
From: Simon Horman <horms@...nel.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: airoha: Add FLOW_CLS_STATS callback
 support

On Fri, May 16, 2025 at 10:00:00AM +0200, Lorenzo Bianconi wrote:

...

> @@ -1027,6 +1255,15 @@ int airoha_ppe_init(struct airoha_eth *eth)
>  	if (!ppe->foe_flow)
>  		return -ENOMEM;
>  
> +	foe_size = PPE_STATS_NUM_ENTRIES * sizeof(*ppe->foe_stats);
> +	if (foe_size) {

Hi Lorenzo,

It's unclear to me how foe_size can be zero.

> +		ppe->foe_stats = dmam_alloc_coherent(eth->dev, foe_size,
> +						     &ppe->foe_stats_dma,
> +						     GFP_KERNEL);
> +		if (!ppe->foe_stats)
> +			return -ENOMEM;
> +	}
> +
>  	err = rhashtable_init(&eth->flow_table, &airoha_flow_table_params);
>  	if (err)
>  		return err;

...