netdev - Re: [PATCH net-next v2 10/12] tools: ynl: enable codegen for TC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250520193625.6d6bc18b@kmaincent-XPS-13-7390>
Date: Tue, 20 May 2025 19:36:25 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 donald.hunter@...il.com, jacob.e.keller@...el.com, sdf@...ichev.me,
 jstancek@...hat.com
Subject: Re: [PATCH net-next v2 10/12] tools: ynl: enable codegen for TC

On Tue, 20 May 2025 09:50:05 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> On Tue, 20 May 2025 18:34:16 +0200 Kory Maincent wrote:
> > > We are ready to support most of TC. Enable C code gen.
> > > 
> > > Reviewed-by: Donald Hunter <donald.hunter@...il.com>
> > > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > > ---
> > > v2:
> > >  - add more headers to the local includes to build on Ubuntu 22.04
> > > v1: https://lore.kernel.org/20250517001318.285800-10-kuba@kernel.org
> > > ---    
> > 
> > Now got this build error:
> > 
> > -e 	GEN tc-user.c
> > -e 	GEN tc-user.h
> > -e 	GEN_RST tc.rst
> > -e 	CC tc-user.o
> > In file included from <command-line>:
> > ./../../../../include/uapi//linux/pkt_cls.h:250:9: error: expected
> > specifier-qualifier-list before ‘__struct_group’ 250 |
> > __struct_group(tc_u32_sel_hdr, hdr, /* no attrs */, |         ^~~~~~~~~~~~~~
> > tc-user.c: In function ‘tc_u32_attrs_parse’:
> > tc-user.c:9086:33: warning: comparison is always false due to limited range
> > of data type [-Wtype-limits] 9086 |                         if (len <
> > sizeof(struct tc_u32_sel)) |                                 ^
> > make[1]: *** [Makefile:52: tc-user.o] Error 1  
> 
> Odd, are you sure you have the latest headers for Ubuntu 22.04?

Indeed I wasn't but after an update I still got the same error.
More precisely I am on Ubuntu 22.04.5 LTS. linux-headers-5.15.0-140

> I added Ubuntu 22.04 to the GitHub build tester and it passes
> there:
> https://github.com/linux-netdev/ynl-c/actions/runs/15143226607/job/42572497918

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com