netdev - Re: [PATCH net-next v2 10/12] tools: ynl: enable codegen for TC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250521133138.0c164028@kernel.org>
Date: Wed, 21 May 2025 13:31:38 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 donald.hunter@...il.com, jacob.e.keller@...el.com, sdf@...ichev.me,
 jstancek@...hat.com
Subject: Re: [PATCH net-next v2 10/12] tools: ynl: enable codegen for TC

On Tue, 20 May 2025 19:36:25 +0200 Kory Maincent wrote:
> > > Now got this build error:
> > > 
> > > -e 	GEN tc-user.c
> > > -e 	GEN tc-user.h
> > > -e 	GEN_RST tc.rst
> > > -e 	CC tc-user.o
> > > In file included from <command-line>:
> > > ./../../../../include/uapi//linux/pkt_cls.h:250:9: error: expected
> > > specifier-qualifier-list before ‘__struct_group’ 250 |
> > > __struct_group(tc_u32_sel_hdr, hdr, /* no attrs */, |         ^~~~~~~~~~~~~~
> > > tc-user.c: In function ‘tc_u32_attrs_parse’:
> > > tc-user.c:9086:33: warning: comparison is always false due to limited range
> > > of data type [-Wtype-limits] 9086 |                         if (len <
> > > sizeof(struct tc_u32_sel)) |                                 ^
> > > make[1]: *** [Makefile:52: tc-user.o] Error 1    
> > 
> > Odd, are you sure you have the latest headers for Ubuntu 22.04?  
> 
> Indeed I wasn't but after an update I still got the same error.
> More precisely I am on Ubuntu 22.04.5 LTS. linux-headers-5.15.0-140

I tried to fix this but stddef includes compiler_types.h, which is 
a non-uAPI header, apparently this gets stripped during header
installation, but there is no guard around it, so our current hack
of including the header directly doesn't work.

__struct_group() was added in v5.16, and v5.15 stable tree pulled 
it in for v5.15.142, 1.5 years ago. But latest Ubuntu 22.04 package 
with user space headers is linux-libc-dev_5.15.0-25.25_amd64.deb (note
that linux-headers is for kernel headers, eg to built a OOT module),
which AFAICT is 3 years old.

All in all your kernel headers are pretty old. I will try to fix this
separately, but let's not hold up this series :( You can update that
one header in your /usr/include/linux and everything else should work.