netdev - Re: [PATCH (EXPERIMENTAL)] team: replace term lock with rtnl lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ooxxjzmbid3jb4optotv5ptzdh253wgwi3v3omo5r7rxl6vqac@7l4rrug5l2z5>
Date: Tue, 20 May 2025 11:23:14 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Hillf Danton <hdanton@...a.com>, 
	Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH (EXPERIMENTAL)] team: replace term lock with rtnl lock

Sat, May 17, 2025 at 09:32:20AM +0200, penguin-kernel@...ove.SAKURA.ne.jp wrote:

[..]

>@@ -2319,13 +2301,12 @@ static struct team *team_nl_team_get(struct genl_info *info)
> 	}
> 
> 	team = netdev_priv(dev);
>-	mutex_lock(&team->lock);
> 	return team;
> }


Why do you think this is safe?

Rtnl is held only for set doit.


> 
> static void team_nl_team_put(struct team *team)
> {
>-	mutex_unlock(&team->lock);
>+	ASSERT_RTNL();

Did you test this? How? Howcome you didn't hit this assertion?



> 	dev_put(team->dev);
> }
>