netdev - Re: [PATCH (EXPERIMENTAL)] team: replace term lock with rtnl lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a12cdc9-1332-4ae5-8639-c71c91336b99@I-love.SAKURA.ne.jp>
Date: Wed, 21 May 2025 22:54:51 +0900
From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
        Hillf Danton <hdanton@...a.com>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH (EXPERIMENTAL)] team: replace term lock with rtnl lock

On 2025/05/18 0:09, Jakub Kicinski wrote:
> I think this was a trylock because there are places we try to cancel
> this work while already holding the lock.

I checked rtnl_unlock(), and it seems to me that rtnl_unlock() calls mutex_unlock() before
doing operations that might sleep. Then, rtnl_unlock() itself won't increase possibility of
rtnl_trylock() failure...

> 
> FWIW I'm not opposed to the patch. Could you wait a week and repost,
> tho? We have a fix queued up in another tree - 6b1d3c5f675cc7
> if we apply your patch to net-next there will be a build failure 
> on merge. Not a showstopper but we'll merge the trees on Thu so it
> can be easily avoided if we wait until then.

I reposted https://lkml.kernel.org/r/d4047311-5644-4884-84c0-059bbb9e98ee@I-love.SAKURA.ne.jp
also as a fix for a new report ( https://syzkaller.appspot.com/bug?extid=b191b5ccad8d7a986286 )
triggered by 6b1d3c5f675cc7.