netdev - Re: [PATCH 6/7] net: core: Convert dev_set_mac_address() to struct sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202505212149.6QGSFucw-lkp@intel.com>
Date: Wed, 21 May 2025 21:42:23 +0800
From: kernel test robot <lkp@...el.com>
To: Kees Cook <kees@...nel.org>, Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: oe-kbuild-all@...ts.linux.dev, Kees Cook <kees@...nel.org>,
	Jakub Kicinski <kuba@...nel.org>, Jay Vosburgh <jv@...sburgh.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	Jiri Pirko <jiri@...nulli.us>, Simon Horman <horms@...nel.org>,
	Alexander Aring <alex.aring@...il.com>,
	Stefan Schmidt <stefan@...enfreihafen.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Samuel Mendoza-Jonas <sam@...dozajonas.com>,
	Paul Fertser <fercerpav@...il.com>,
	Hayes Wang <hayeswang@...ltek.com>,
	Douglas Anderson <dianders@...omium.org>,
	Grant Grundler <grundler@...omium.org>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Cosmin Ratiu <cratiu@...dia.com>, Lei Yang <leiyang@...hat.com>,
	netdev@...r.kernel.org, linux-hyperv@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-wpan@...r.kernel.org,
	Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>
Subject: Re: [PATCH 6/7] net: core: Convert dev_set_mac_address() to struct
 sockaddr_storage

Hi Kees,

kernel test robot noticed the following build errors:

[auto build test ERROR on linux-nvme/for-next]
[also build test ERROR on mkp-scsi/for-next kees/for-next/pstore kees/for-next/kspp linus/master v6.15-rc7 next-20250521]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kees-Cook/net-core-Convert-inet_addr_is_any-to-sockaddr_storage/20250521-063445
base:   git://git.infradead.org/nvme.git for-next
patch link:    https://lore.kernel.org/r/20250520223108.2672023-6-kees%40kernel.org
patch subject: [PATCH 6/7] net: core: Convert dev_set_mac_address() to struct sockaddr_storage
config: arc-randconfig-001-20250521 (https://download.01.org/0day-ci/archive/20250521/202505212149.6QGSFucw-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250521/202505212149.6QGSFucw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505212149.6QGSFucw-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/core/dev_api.c: In function 'dev_set_mac_address':
>> net/core/dev_api.c:318:35: error: 'sa' undeclared (first use in this function); did you mean 'ss'?
     318 |  ret = netif_set_mac_address(dev, sa, extack);
         |                                   ^~
         |                                   ss
   net/core/dev_api.c:318:35: note: each undeclared identifier is reported only once for each function it appears in


vim +318 net/core/dev_api.c

   301	
   302	/**
   303	 * dev_set_mac_address() - change Media Access Control Address
   304	 * @dev: device
   305	 * @ss: new address
   306	 * @extack: netlink extended ack
   307	 *
   308	 * Change the hardware (MAC) address of the device
   309	 *
   310	 * Return: 0 on success, -errno on failure.
   311	 */
   312	int dev_set_mac_address(struct net_device *dev, struct sockaddr_storage *ss,
   313				struct netlink_ext_ack *extack)
   314	{
   315		int ret;
   316	
   317		netdev_lock_ops(dev);
 > 318		ret = netif_set_mac_address(dev, sa, extack);
   319		netdev_unlock_ops(dev);
   320	
   321		return ret;
   322	}
   323	EXPORT_SYMBOL(dev_set_mac_address);
   324	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki