netdev - Re: [net PATCH v3] octeontx2-af: Send Link events one by one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC2yZ6PqKf5lmJQk@mev-dev.igk.intel.com>
Date: Wed, 21 May 2025 13:00:55 +0200
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Subbaraya Sundeep <sbhatta@...vell.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	michal.swiatkowski@...ux.intel.com, gakula@...vell.com,
	hkelam@...vell.com, sgoutham@...vell.com, lcherian@...vell.com,
	bbhushan2@...vell.com, jerinj@...vell.com, netdev@...r.kernel.org
Subject: Re: [net PATCH v3] octeontx2-af: Send Link events one by one

On Wed, May 21, 2025 at 04:00:43PM +0530, Subbaraya Sundeep wrote:
> Send link events one after another otherwise new message
> is overwriting the message which is being processed by PF.
> 
> Fixes: a88e0f936ba9 ("octeontx2: Detect the mbox up or down message via register")
> Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> ---
> v3:
>  Modifid to wait for response at other places mcs_notify_pfvf
>  and rvu_rep_up_notify as suggested by Simon Hormon and Michal Swiatkowski.
> v2:
>  No changes. Added subject prefix net.
> 
>  drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c | 2 ++
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c    | 2 ++
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_rep.c    | 2 ++
>  3 files changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c b/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
> index 655dd47..0277d22 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
> @@ -143,6 +143,8 @@ static int mcs_notify_pfvf(struct mcs_intr_event *event, struct rvu *rvu)
>  
>  	otx2_mbox_msg_send_up(&rvu->afpf_wq_info.mbox_up, pf);
>  
> +	otx2_mbox_wait_for_rsp(&rvu->afpf_wq_info.mbox_up, pf);
> +
>  	mutex_unlock(&rvu->mbox_lock);
>  
>  	return 0;
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> index 992fa0b..ebb56eb 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> @@ -272,6 +272,8 @@ static void cgx_notify_pfs(struct cgx_link_event *event, struct rvu *rvu)
>  
>  		otx2_mbox_msg_send_up(&rvu->afpf_wq_info.mbox_up, pfid);
>  
> +		otx2_mbox_wait_for_rsp(&rvu->afpf_wq_info.mbox_up, pfid);
> +
>  		mutex_unlock(&rvu->mbox_lock);
>  	} while (pfmap);
>  }
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_rep.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_rep.c
> index 052ae59..32953cc 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_rep.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_rep.c
> @@ -60,6 +60,8 @@ static int rvu_rep_up_notify(struct rvu *rvu, struct rep_event *event)
>  
>  	otx2_mbox_msg_send_up(&rvu->afpf_wq_info.mbox_up, pf);
>  
> +	otx2_mbox_wait_for_rsp(&rvu->afpf_wq_info.mbox_up, pf);
> +
>  	mutex_unlock(&rvu->mbox_lock);
>  	return 0;

Thanks for the change
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

>  }
> -- 
> 2.7.4
>