netdev - Re: [PATCH net] team: replace team lock with rtnl lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250521110024.64f5e422@kernel.org>
Date: Wed, 21 May 2025 11:00:24 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc: Network Development <netdev@...r.kernel.org>, Jiri Pirko
 <jiri@...nulli.us>, Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Hillf Danton <hdanton@...a.com>, Stanislav Fomichev
 <stfomichev@...il.com>, Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net] team: replace team lock with rtnl lock

On Wed, 21 May 2025 22:38:55 +0900 Tetsuo Handa wrote:
> syzbot is reporting locking order problem between wiphy and team.
> As per Jiri Pirko's comment, let's check whether all callers are
> already holding rtnl lock. This patch will help simplifying locking
> dependency if all callers are already holding rtnl lock.
> 
> Reported-by: syzbot+705c61d60b091ef42c04@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=705c61d60b091ef42c04
> Suggested-by: Jiri Pirko <jiri@...nulli.us>

I don't think Jiri suggested it, he provided a review and asked
questions. Suggest means he is the proponent of the patch.
And as he pointed out this patch promptly generates all sort 
of locking warnings, please test this properly.