netdev - Re: [PATCH net] team: replace team lock with rtnl lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec84752c-1e3d-413c-9c2b-6d83e48470ef@I-love.SAKURA.ne.jp>
Date: Thu, 22 May 2025 10:00:58 +0900
From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Network Development <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
        Hillf Danton <hdanton@...a.com>,
        Stanislav Fomichev <stfomichev@...il.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net] team: replace team lock with rtnl lock

On 2025/05/22 3:00, Jakub Kicinski wrote:
> On Wed, 21 May 2025 22:38:55 +0900 Tetsuo Handa wrote:
>> syzbot is reporting locking order problem between wiphy and team.
>> As per Jiri Pirko's comment, let's check whether all callers are
>> already holding rtnl lock. This patch will help simplifying locking
>> dependency if all callers are already holding rtnl lock.
>>
>> Reported-by: syzbot+705c61d60b091ef42c04@...kaller.appspotmail.com
>> Closes: https://syzkaller.appspot.com/bug?extid=705c61d60b091ef42c04
>> Suggested-by: Jiri Pirko <jiri@...nulli.us>
> 
> I don't think Jiri suggested it, he provided a review and asked
> questions. Suggest means he is the proponent of the patch.

I think Jiri Pirko knows better than I, for Jiri is the maintainer of
TEAM DRIVER. I just tried what Jiri commented:

  I wonder, since we already rely on rtnl in lots of team code, perhaps we
  can remove team->lock completely and convert the rest of the code to be
  protected by rtnl lock as well

> And as he pointed out this patch promptly generates all sort 
> of locking warnings, please test this properly.

I didn't get any compile-time warnings, and
https://lkml.kernel.org/r/682e6b1f.a00a0220.2a3337.0007.GAE@google.com didn't
get any run-time locking warnings.

What locking warnings did you get? Is there an automated testing environment
(like https://lkml.kernel.org/r/66a4b1a7.050a0220.12c792.8f9e@mx.google.com )
which I can use for testing this patch?