netdev - Re: [PATCH net] team: replace team lock with rtnl lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qfgrrkuo6bvkfhuhyk767gsrlkloactjeldlqgtwxpklwl54pp@a4cy5ip3m3kz>
Date: Thu, 22 May 2025 12:04:12 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc: Network Development <netdev@...r.kernel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Hillf Danton <hdanton@...a.com>, 
	Stanislav Fomichev <stfomichev@...il.com>, Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net] team: replace team lock with rtnl lock

Wed, May 21, 2025 at 03:38:55PM +0200, penguin-kernel@...ove.SAKURA.ne.jp wrote:

[...]

>@@ -2319,13 +2300,12 @@ static struct team *team_nl_team_get(struct genl_info *info)
> 	}
> 
> 	team = netdev_priv(dev);
>-	mutex_lock(&team->lock);
> 	return team;
> }
> 
> static void team_nl_team_put(struct team *team)
> {
>-	mutex_unlock(&team->lock);
>+	ASSERT_RTNL();
> 	dev_put(team->dev);
> }
> 

I don't understand. Why do you ignored my comments to these 2 hunks?