netdev - RE: [PATCH v10 net-next 4/8] net: ena: Control PHC enable through devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44f411e08eec474394794ac892f12554@amazon.com>
Date: Thu, 22 May 2025 16:07:03 +0000
From: "Arinzon, David" <darinzon@...zon.com>
To: Jiri Pirko <jiri@...nulli.us>
CC: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Eric Dumazet
	<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, Richard Cochran <richardcochran@...il.com>, "Woodhouse,
 David" <dwmw@...zon.co.uk>, "Machulsky, Zorik" <zorik@...zon.com>,
	"Matushevsky, Alexander" <matua@...zon.com>, "Bshara, Saeed"
	<saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>, "Liguori, Anthony"
	<aliguori@...zon.com>, "Bshara, Nafea" <nafea@...zon.com>, "Schmeilin,
 Evgeny" <evgenys@...zon.com>, "Belgazal, Netanel" <netanel@...zon.com>,
	"Saidi, Ali" <alisaidi@...zon.com>, "Herrenschmidt, Benjamin"
	<benh@...zon.com>, "Kiyanovski, Arthur" <akiyano@...zon.com>, "Dagan, Noam"
	<ndagan@...zon.com>, "Bernstein, Amit" <amitbern@...zon.com>, "Allen, Neil"
	<shayagr@...zon.com>, "Ostrovsky, Evgeny" <evostrov@...zon.com>, "Tabachnik,
 Ofir" <ofirt@...zon.com>, "Machnikowski, Maciek" <maciek@...hnikowski.net>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>, Gal Pressman <gal@...dia.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Andrew Lunn <andrew@...n.ch>,
	Leon Romanovsky <leon@...nel.org>
Subject: RE: [PATCH v10 net-next 4/8] net: ena: Control PHC enable through devlink

> >> >> >+enum ena_devlink_param_id {
> >> >> >+      ENA_DEVLINK_PARAM_ID_BASE =
> >> >> DEVLINK_PARAM_GENERIC_ID_MAX,
> >> >> >+      ENA_DEVLINK_PARAM_ID_PHC_ENABLE,
> >> >>
> >> >> What exactly is driver/vendor specific about this? Sounds quite
> >> >> generic to me.
> >> >
> >> >Can you please clarify the question?
> >> >If you refer to the need of ENA_DEVLINK_PARAM_ID_PHC_ENABLE, it
> was
> >> >discussed as part of patchset v8 in
> >> >https://lore.kernel.org/netdev/20250304190504.3743-6-
> >> darinzon@...zon.co
> >> >m/ More specifically in
> >>
> >https://lore.kernel.org/netdev/55f9df6241d052a91dfde950af04c70969ea2
> >> >8
> >> b2
> >> >.camel@...radead.org/
> >> >
> >>
> >> Could you please read "Generic configuration parameters" section of
> >> Documentation/networking/devlink/devlink-params.rst? Perhaps that
> >> would help. So basically my question is, why your new param can't go in
> that list?
> >
> >Thanks for the clarification.
> >This is a topic that has been discussed in the versions of this
> >patchset, specifically in
> >https://lore.kernel.org/netdev/20250304190504.3743-6-
> darinzon@...zon.co
> >m/
> 
> Where exactly?

The discussion is from https://lore.kernel.org/netdev/20250304190504.3743-6-darinzon@amazon.com/ and split into two sub-threads
The suggestion to use devlink is from https://lore.kernel.org/netdev/20250402092344.5a12a26a@kernel.org/

> 
> 
> >Other modules in the kernel enable PHC unconditionally, due to
> >potential blast radius concerns, we've decided to not enable the feature
> unconditionally and allow customers to enable it if they choose to use the
> functionality.
> >As this is a specific behavior for the ENA driver, we've added a specific
> devlink parameter (was a sysfs entry previously and changed to devlink in v9
> due to feedback).
> 
> Why is this specific to ENA? Why any other driver can't have the same knob
> to enable/disable PHC?
> 

If there are no objections, I can add a generic command instead of a specific one.