netdev - Re: [PATCH linux next v2] net: neigh: use kfree_skb_reason() in neigh_resolve_output() and neigh_connected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250522142128347DhUL47l1VoaTNFU4XV7h4@zte.com.cn>
Date: Thu, 22 May 2025 14:21:28 +0800 (CST)
From: <xu.xin16@....com.cn>
To: <jiang.kun2@....com.cn>
Cc: <horms@...nel.org>, <kuniyu@...zon.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <fan.yu9@....com.cn>, <gnaaman@...venets.com>,
        <he.peilin@....com.cn>, <kuba@...nel.org>, <leitao@...ian.org>,
        <linux-kernel@...r.kernel.org>, <lizetao1@...wei.com>,
        <netdev@...r.kernel.org>, <pabeni@...hat.com>, <qiu.yutan@....com.cn>,
        <tu.qiang35@....com.cn>, <wang.yaxin@....com.cn>,
        <yang.yang29@....com.cn>, <ye.xingchen@....com.cn>,
        <zhang.yunkai@....com.cn>
Subject: Re: [PATCH linux next v2] net: neigh: use kfree_skb_reason() in neigh_resolve_output() and neigh_connected_output()

> From: Qiu Yutan <qiu.yutan@....com.cn>
> 
> Replace kfree_skb() used in neigh_resolve_output() and
> neigh_connected_output() with kfree_skb_reason().
> 
> Following new skb drop reason is added:
> /* failed to fill the device hard header */
> SKB_DROP_REASON_NEIGH_HH_FILLFAIL
> 
> Signed-off-by: Qiu Yutan <qiu.yutan@....com.cn>
> Signed-off-by: Jiang Kun <jiang.kun2@....com.cn>

Looks good to me.
Reviewed-by: Xu Xin <xu.xin16@....com.cn>