netdev - Re: [PATCH linux next v2] net: neigh: use kfree_skb_reason() in neigh_resolve_output() and neigh_connected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250527180913.4b9f1027@kernel.org>
Date: Tue, 27 May 2025 18:09:13 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: <jiang.kun2@....com.cn>
Cc: <horms@...nel.org>, <kuniyu@...zon.com>, <davem@...emloft.net>,
 <edumazet@...gle.com>, <fan.yu9@....com.cn>, <gnaaman@...venets.com>,
 <he.peilin@....com.cn>, <leitao@...ian.org>,
 <linux-kernel@...r.kernel.org>, <lizetao1@...wei.com>,
 <netdev@...r.kernel.org>, <pabeni@...hat.com>, <qiu.yutan@....com.cn>,
 <tu.qiang35@....com.cn>, <wang.yaxin@....com.cn>, <xu.xin16@....com.cn>,
 <yang.yang29@....com.cn>, <ye.xingchen@....com.cn>,
 <zhang.yunkai@....com.cn>
Subject: Re: [PATCH linux next v2] net: neigh: use kfree_skb_reason() in
 neigh_resolve_output() and neigh_connected_output()

On Wed, 21 May 2025 10:14:08 +0800 (CST) jiang.kun2@....com.cn wrote:
> From: Qiu Yutan <qiu.yutan@....com.cn>
> 
> Replace kfree_skb() used in neigh_resolve_output() and
> neigh_connected_output() with kfree_skb_reason().
> 
> Following new skb drop reason is added:
> /* failed to fill the device hard header */
> SKB_DROP_REASON_NEIGH_HH_FILLFAIL

Looks like this got applied already but can you explain for which
protocol you see these drops? I checked random few and none of them
can fail in ->create().