[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <68c3346d-98c4-409a-a772-4f8fe31be57b@redhat.com>
Date: Tue, 27 May 2025 16:13:09 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Tonghao Zhang <tonghao@...aicloud.com>, netdev@...r.kernel.org
Cc: Jay Vosburgh <jv@...sburgh.net>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
Andrew Lunn <andrew+netdev@...n.ch>, Steven Rostedt <rostedt@...dmis.org>,
Masami Hiramatsu <mhiramat@...nel.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Nikolay Aleksandrov <razor@...ckwall.org>,
Zengbing Tu <tuzengbing@...iglobal.com>
Subject: Re: [PATCH RESEND net-next v5 3/4] net: bonding: send peer notify
when failure recovery
5/27/25 4:09 PM, Paolo Abeni wrote:
> On 5/22/25 10:55 AM, Tonghao Zhang wrote:
>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>> index b5c34d7f126c..7f03ca9bcbba 100644
>> --- a/drivers/net/bonding/bond_main.c
>> +++ b/drivers/net/bonding/bond_main.c
>> @@ -1242,17 +1242,28 @@ static struct slave *bond_find_best_slave(struct bonding *bond)
>> /* must be called in RCU critical section or with RTNL held */
>> static bool bond_should_notify_peers(struct bonding *bond)
>> {
>> - struct slave *slave = rcu_dereference_rtnl(bond->curr_active_slave);
>> + struct bond_up_slave *usable;
>> + struct slave *slave = NULL;
>>
>> - if (!slave || !bond->send_peer_notif ||
>> + if (!bond->send_peer_notif ||
>> bond->send_peer_notif %
>> max(1, bond->params.peer_notif_delay) != 0 ||
>> - !netif_carrier_ok(bond->dev) ||
>> - test_bit(__LINK_STATE_LINKWATCH_PENDING, &slave->dev->state))
>> + !netif_carrier_ok(bond->dev))
>> return false;
>>
>> + if (BOND_MODE(bond) == BOND_MODE_8023AD) {
>> + usable = rcu_dereference_rtnl(bond->usable_slaves);
>> + if (!usable || !READ_ONCE(usable->count))
>> + return false;
>
> The above unconditionally changes the current behavior for
> BOND_MODE_8023AD regardless of the `broadcast_neighbor` value. Why the
> new behavior is not conditioned by broadcast_neighbor == true?
Not strictly related to this patch, but as a new feature this deserve an
additional test-case.
Note that the series is not threaded correctly in PW - the cover letter
does not belong to this thread. Please adjust that, thanks!
Paolo
Powered by blists - more mailing lists