| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202505271459.ZZab1GQF-lkp@intel.com>
Date: Tue, 27 May 2025 14:46:37 +0800
From: kernel test robot <lkp@...el.com>
To: Subbaraya Sundeep <sbhatta@...vell.com>, andrew+netdev@...n.ch,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, horms@...nel.org, saikrishnag@...vell.com,
gakula@...vell.com, hkelam@...vell.com, sgoutham@...vell.com,
lcherian@...vell.com, bbhushan2@...vell.com, jerinj@...vell.com
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
Subbaraya Sundeep <sbhatta@...vell.com>
Subject: Re: [net PATCH] octeontx2-pf: Avoid typecasts by simplifying
otx2_atomic64_add macro
Hi Subbaraya,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net/main]
url: https://github.com/intel-lab-lkp/linux/commits/Subbaraya-Sundeep/octeontx2-pf-Avoid-typecasts-by-simplifying-otx2_atomic64_add-macro/20250526-234505
base: net/main
patch link: https://lore.kernel.org/r/1748274232-20835-1-git-send-email-sbhatta%40marvell.com
patch subject: [net PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20250527/202505271459.ZZab1GQF-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250527/202505271459.ZZab1GQF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505271459.ZZab1GQF-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:22:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c: In function 'otx2_q_intr_handler':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1314:23: note: in expansion of macro 'otx2_atomic64_add'
1314 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1314:23: note: in expansion of macro 'otx2_atomic64_add'
1314 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1353:23: note: in expansion of macro 'otx2_atomic64_add'
1353 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1353:23: note: in expansion of macro 'otx2_atomic64_add'
1353 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^~~~~~~~~~~~~~~~~
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:17:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c: In function 'otx2_nix_rq_op_stats':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:34:24: note: in expansion of macro 'otx2_atomic64_add'
34 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:34:24: note: in expansion of macro 'otx2_atomic64_add'
34 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:37:23: note: in expansion of macro 'otx2_atomic64_add'
37 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:37:23: note: in expansion of macro 'otx2_atomic64_add'
37 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c: In function 'otx2_nix_sq_op_stats':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:47:24: note: in expansion of macro 'otx2_atomic64_add'
47 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:47:24: note: in expansion of macro 'otx2_atomic64_add'
47 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:50:23: note: in expansion of macro 'otx2_atomic64_add'
50 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:50:23: note: in expansion of macro 'otx2_atomic64_add'
50 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c: In function 'otx2_sqb_flush':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:873:23: note: in expansion of macro 'otx2_atomic64_add'
873 | val = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:873:23: note: in expansion of macro 'otx2_atomic64_add'
873 | val = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:805:1: warning: control reaches end of non-void function [-Wreturn-type]
805 | }
| ^
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:18:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/cn10k.h:11,
from drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c:11:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c: In function 'otx2_qos_sqb_flush':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c:159:15: note: in expansion of macro 'otx2_atomic64_add'
159 | val = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c:159:15: note: in expansion of macro 'otx2_atomic64_add'
159 | val = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:805:1: warning: control reaches end of non-void function [-Wreturn-type]
805 | }
| ^
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_xsk.c:13:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:805:1: warning: control reaches end of non-void function [-Wreturn-type]
805 | }
| ^
vim +751 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
caa2da34fd25a3 Sunil Goutham 2020-01-27 748
caa2da34fd25a3 Sunil Goutham 2020-01-27 749 #else
4c236d5dc8b862 Geetha sowjanya 2021-02-11 750 #define otx2_write128(lo, hi, addr) writeq((hi) | (lo), addr)
caa2da34fd25a3 Sunil Goutham 2020-01-27 @751 #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
caa2da34fd25a3 Sunil Goutham 2020-01-27 752 #endif
caa2da34fd25a3 Sunil Goutham 2020-01-27 753
4c236d5dc8b862 Geetha sowjanya 2021-02-11 754 static inline void __cn10k_aura_freeptr(struct otx2_nic *pfvf, u64 aura,
ef6c8da71eaffe Geetha sowjanya 2021-09-01 755 u64 *ptrs, u64 num_ptrs)
4c236d5dc8b862 Geetha sowjanya 2021-02-11 756 {
ef6c8da71eaffe Geetha sowjanya 2021-09-01 757 struct otx2_lmt_info *lmt_info;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 758 u64 size = 0, count_eot = 0;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 759 u64 tar_addr, val = 0;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 760
ef6c8da71eaffe Geetha sowjanya 2021-09-01 761 lmt_info = per_cpu_ptr(pfvf->hw.lmt_info, smp_processor_id());
4c236d5dc8b862 Geetha sowjanya 2021-02-11 762 tar_addr = (__force u64)otx2_get_regaddr(pfvf, NPA_LF_AURA_BATCH_FREE0);
4c236d5dc8b862 Geetha sowjanya 2021-02-11 763 /* LMTID is same as AURA Id */
ef6c8da71eaffe Geetha sowjanya 2021-09-01 764 val = (lmt_info->lmt_id & 0x7FF) | BIT_ULL(63);
4c236d5dc8b862 Geetha sowjanya 2021-02-11 765 /* Set if [127:64] of last 128bit word has a valid pointer */
4c236d5dc8b862 Geetha sowjanya 2021-02-11 766 count_eot = (num_ptrs % 2) ? 0ULL : 1ULL;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 767 /* Set AURA ID to free pointer */
4c236d5dc8b862 Geetha sowjanya 2021-02-11 768 ptrs[0] = (count_eot << 32) | (aura & 0xFFFFF);
4c236d5dc8b862 Geetha sowjanya 2021-02-11 769 /* Target address for LMTST flush tells HW how many 128bit
4c236d5dc8b862 Geetha sowjanya 2021-02-11 770 * words are valid from NPA_LF_AURA_BATCH_FREE0.
4c236d5dc8b862 Geetha sowjanya 2021-02-11 771 *
4c236d5dc8b862 Geetha sowjanya 2021-02-11 772 * tar_addr[6:4] is LMTST size-1 in units of 128b.
4c236d5dc8b862 Geetha sowjanya 2021-02-11 773 */
4c236d5dc8b862 Geetha sowjanya 2021-02-11 774 if (num_ptrs > 2) {
4c236d5dc8b862 Geetha sowjanya 2021-02-11 775 size = (sizeof(u64) * num_ptrs) / 16;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 776 if (!count_eot)
4c236d5dc8b862 Geetha sowjanya 2021-02-11 777 size++;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 778 tar_addr |= ((size - 1) & 0x7) << 4;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 779 }
c5d731c54a1767 Geetha sowjanya 2022-01-21 780 dma_wmb();
ef6c8da71eaffe Geetha sowjanya 2021-09-01 781 memcpy((u64 *)lmt_info->lmt_addr, ptrs, sizeof(u64) * num_ptrs);
4c236d5dc8b862 Geetha sowjanya 2021-02-11 782 /* Perform LMTST flush */
4c236d5dc8b862 Geetha sowjanya 2021-02-11 783 cn10k_lmt_flush(val, tar_addr);
4c236d5dc8b862 Geetha sowjanya 2021-02-11 784 }
4c236d5dc8b862 Geetha sowjanya 2021-02-11 785
4c236d5dc8b862 Geetha sowjanya 2021-02-11 786 static inline void cn10k_aura_freeptr(void *dev, int aura, u64 buf)
4c236d5dc8b862 Geetha sowjanya 2021-02-11 787 {
4c236d5dc8b862 Geetha sowjanya 2021-02-11 788 struct otx2_nic *pfvf = dev;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 789 u64 ptrs[2];
4c236d5dc8b862 Geetha sowjanya 2021-02-11 790
4c236d5dc8b862 Geetha sowjanya 2021-02-11 791 ptrs[1] = buf;
55ba18dc62deff Kevin Hao 2023-01-18 792 get_cpu();
ef6c8da71eaffe Geetha sowjanya 2021-09-01 793 /* Free only one buffer at time during init and teardown */
ef6c8da71eaffe Geetha sowjanya 2021-09-01 794 __cn10k_aura_freeptr(pfvf, aura, ptrs, 2);
55ba18dc62deff Kevin Hao 2023-01-18 795 put_cpu();
4c236d5dc8b862 Geetha sowjanya 2021-02-11 796 }
4c236d5dc8b862 Geetha sowjanya 2021-02-11 797
caa2da34fd25a3 Sunil Goutham 2020-01-27 798 /* Alloc pointer from pool/aura */
caa2da34fd25a3 Sunil Goutham 2020-01-27 799 static inline u64 otx2_aura_allocptr(struct otx2_nic *pfvf, int aura)
caa2da34fd25a3 Sunil Goutham 2020-01-27 800 {
22f5790bc6ba33 Subbaraya Sundeep 2025-05-26 801 void __iomem *ptr = otx2_get_regaddr(pfvf, NPA_LF_AURA_OP_ALLOCX(0));
caa2da34fd25a3 Sunil Goutham 2020-01-27 802 u64 incr = (u64)aura | BIT_ULL(63);
caa2da34fd25a3 Sunil Goutham 2020-01-27 803
caa2da34fd25a3 Sunil Goutham 2020-01-27 @804 return otx2_atomic64_add(incr, ptr);
caa2da34fd25a3 Sunil Goutham 2020-01-27 @805 }
caa2da34fd25a3 Sunil Goutham 2020-01-27 806
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists