netdev - Re: [PATCH net-next v2 8/8] net: core: Convert dev_set_mac_address_user() to use struct sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1429351-3c9b-40e0-b50d-de6527d0a05b@redhat.com>
Date: Tue, 27 May 2025 09:02:28 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kees Cook <kees@...nel.org>, Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Jason Wang <jasowang@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Cosmin Ratiu <cratiu@...dia.com>,
 Vladimir Oltean <vladimir.oltean@....com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Kory Maincent <kory.maincent@...tlin.com>, Maxim Georgiev
 <glipus@...il.com>, netdev@...r.kernel.org,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
 Chaitanya Kulkarni <kch@...dia.com>,
 Mike Christie <michael.christie@...cle.com>,
 Max Gurtovoy <mgurtovoy@...dia.com>, Maurizio Lombardi
 <mlombard@...hat.com>, Dmitry Bogdanov <d.bogdanov@...ro.com>,
 Mingzhe Zou <mingzhe.zou@...ystack.cn>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 "Dr. David Alan Gilbert" <linux@...blig.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>, Lei Yang
 <leiyang@...hat.com>, Ido Schimmel <idosch@...dia.com>,
 Samuel Mendoza-Jonas <sam@...dozajonas.com>,
 Paul Fertser <fercerpav@...il.com>, Alexander Aring <alex.aring@...il.com>,
 Stefan Schmidt <stefan@...enfreihafen.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>, Hayes Wang
 <hayeswang@...ltek.com>, Douglas Anderson <dianders@...omium.org>,
 Grant Grundler <grundler@...omium.org>, Jay Vosburgh <jv@...sburgh.net>,
 "K. Y. Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>, Jiri Pirko <jiri@...nulli.us>,
 Aleksander Jan Bajkowski <olek2@...pl>, Philipp Hahn <phahn-oss@....de>,
 Eric Biggers <ebiggers@...gle.com>, Ard Biesheuvel <ardb@...nel.org>,
 Al Viro <viro@...iv.linux.org.uk>, Ahmed Zaki <ahmed.zaki@...el.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Xiao Liang <shaw.leon@...il.com>, linux-kernel@...r.kernel.org,
 linux-nvme@...ts.infradead.org, linux-scsi@...r.kernel.org,
 target-devel@...r.kernel.org, linux-wpan@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-hyperv@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH net-next v2 8/8] net: core: Convert
 dev_set_mac_address_user() to use struct sockaddr_storage

On 5/21/25 10:46 PM, Kees Cook wrote:
> diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c
> index fff13a8b48f1..616479e71466 100644
> --- a/net/core/dev_ioctl.c
> +++ b/net/core/dev_ioctl.c
> @@ -572,9 +572,11 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, void __user *data,
>  		return dev_set_mtu(dev, ifr->ifr_mtu);
>  
>  	case SIOCSIFHWADDR:
> -		if (dev->addr_len > sizeof(struct sockaddr))
> +		if (dev->addr_len > sizeof(ifr->ifr_hwaddr))
>  			return -EINVAL;
> -		return dev_set_mac_address_user(dev, &ifr->ifr_hwaddr, NULL);
> +		return dev_set_mac_address_user(dev,
> +						(struct sockaddr_storage *)&ifr->ifr_hwaddr,
> +						NULL);

Side note for a possible follow-up: the above pattern is repeated a
couple of times: IMHO consolidating it into an helper would be nice.
Also such helper could/should explicitly convert ifr->ifr_hwaddr to
sockaddr_storage and avoid the cast.

/P