netdev - Re: [PATCH ethtool 1/2] module_common: always print per-lane status in JSON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDiC3ZTHzSwZGCXl@shredder>
Date: Thu, 29 May 2025 18:53:01 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: mkubecek@...e.cz, danieller@...dia.com, netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 1/2] module_common: always print per-lane status
 in JSON

On Thu, May 29, 2025 at 07:20:32AM -0700, Jakub Kicinski wrote:
> The JSON output type changes when loss of signal / fault is
> detected. When there is no problem we print single bool, eg:
> 
>   "rx_loss_of_signal": false,
> 
> but when there's a problem we print an array:
> 
>   "rx_loss_of_signal": ["No", "Yes", "No", "No"],
> 
> This appears to be a mirror of the human-readable output,
> but it's a pain to parse / unmarshall for user space.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Ido Schimmel <idosch@...dia.com>