netdev - Re: [PATCH ethtool 2/2] module_common: print loss / fault signals as bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDiC9_sW5VArKBBi@shredder>
Date: Thu, 29 May 2025 18:53:27 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: mkubecek@...e.cz, danieller@...dia.com, netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 2/2] module_common: print loss / fault signals as
 bool

On Thu, May 29, 2025 at 07:20:33AM -0700, Jakub Kicinski wrote:
> JSON output is supposed to be easy to parse. We currently
> output "Yes" / "No" for the per-lane signal loss / fault.
> This forces user space to do string matching. Print bool.
> 
> Before:
>   "rx_loss_of_signal": ["No", "No", "No", "No"],
> 
> After:
>   "rx_loss_of_signal": [false, false, false, false],
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Ido Schimmel <idosch@...dia.com>