netdev - Re: [PATCH v2 net-next 2/7] socket: Rename sock_create_kern() to __sock_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250529222911.37dc04f3@pumpkin>
Date: Thu, 29 May 2025 22:29:11 +0100
From: David Laight <david.laight.linux@...il.com>
To: Christoph Hellwig <hch@....de>
Cc: Kuniyuki Iwashima <kuniyu@...zon.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Willem de Bruijn
 <willemb@...gle.com>, Simon Horman <horms@...nel.org>, Kuniyuki Iwashima
 <kuni1840@...il.com>, Chuck Lever <chuck.lever@...cle.com>, Jeff Layton
 <jlayton@...nel.org>, Matthieu Baerts <matttbe@...nel.org>, Keith Busch
 <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>, Wenjia Zhang
 <wenjia@...ux.ibm.com>, Jan Karcher <jaka@...ux.ibm.com>, Steve French
 <sfrench@...ba.org>, netdev@...r.kernel.org, mptcp@...ts.linux.dev,
 linux-nfs@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v2 net-next 2/7] socket: Rename sock_create_kern() to
 __sock_create_kern().

On Mon, 26 May 2025 07:30:13 +0200
Christoph Hellwig <hch@....de> wrote:

> On Fri, May 23, 2025 at 11:21:08AM -0700, Kuniyuki Iwashima wrote:
> > Let's rename sock_create_kern() to __sock_create_kern() as a special
> > API and add a fat documentation.
> > 
> > The next patch will add sock_create_kern() that holds netns refcnt.  
> 
> Maybe do this before patch 1 to reduce the churn of just touching a
> lot of the same callers again?

You also really want untouched source files to fail to compile.
If nothing else it'll stop backports going badly awry.

	David