[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250530024238.3205130-1-kuni1840@gmail.com>
Date: Thu, 29 May 2025 19:42:36 -0700
From: Kuniyuki Iwashima <kuni1840@...il.com>
To: hch@....de
Cc: axboe@...nel.dk,
chuck.lever@...cle.com,
davem@...emloft.net,
edumazet@...gle.com,
horms@...nel.org,
jaka@...ux.ibm.com,
jlayton@...nel.org,
kbusch@...nel.org,
kuba@...nel.org,
kuni1840@...il.com,
kuniyu@...zon.com,
linux-nfs@...r.kernel.org,
linux-nvme@...ts.infradead.org,
linux-rdma@...r.kernel.org,
matttbe@...nel.org,
mptcp@...ts.linux.dev,
netdev@...r.kernel.org,
pabeni@...hat.com,
sfrench@...ba.org,
wenjia@...ux.ibm.com,
willemb@...gle.com
Subject: Re: [PATCH v2 net-next 1/7] socket: Un-export __sock_create().
From: Christoph Hellwig <hch@....de>
Date: Mon, 26 May 2025 07:29:07 +0200
> On Fri, May 23, 2025 at 11:21:07AM -0700, Kuniyuki Iwashima wrote:
> > Since commit eeb1bd5c40ed ("net: Add a struct net parameter to
> > sock_create_kern"), we no longer need to export __sock_create()
> > and can replace all non-core users with sock_create_kern().
> >
> > Let's convert them and un-export __sock_create().
>
> The changes looks good, but the commit log including subject line
> is rather confusing. What you do is to replace all uses of
> __sock_create with sock_create_kern, which works because
> sock_create_kern just calls __sock_create with the last argument set
> to 1 as those callers do it. This then allows marking __sock_create
> static because all outside users are gone.
>
> Please state that, i.e.
Will do so.
Thanks!
>
> Subect: use sock_create_kern insteadf of opencoding it
>
> Replace all callers of __sock_create that set the kernel argument to 1
> with sock_create_kern, which is the improve interface for that.
> Mark __sock_create static now that all users outside of socket.c
> are gone.
Powered by blists - more mailing lists