netdev - Re: [PATCH net] Revert "kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDnKH1LiYiuWhLA6@finisterre.sirena.org.uk>
Date: Fri, 30 May 2025 16:09:19 +0100
From: Mark Brown <broonie@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, brendan.higgins@...ux.dev,
	davidgow@...gle.com, rmoar@...gle.com, rf@...nsource.cirrus.com,
	mic@...ikod.net, skhan@...uxfoundation.org,
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com
Subject: Re: [PATCH net] Revert "kunit: configs: Enable
 CONFIG_INIT_STACK_ALL_PATTERN in all_tests"

On Fri, May 30, 2025 at 06:58:00AM -0700, Jakub Kicinski wrote:
> This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

> The commit in question breaks kunit for older compilers:

> $ gcc --version
>  gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
> 
> $ ./tools/testing/kunit/kunit.py run  --alltests --json --arch=x86_64
>  Configuring KUnit Kernel ...
>  Regenerating .config ...
>  Populating config with:
>  $ make ARCH=x86_64 O=.kunit olddefconfig
>  ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config.
>  This is probably due to unsatisfied dependencies.
>  Missing: CONFIG_INIT_STACK_ALL_PATTERN=y

This seems like there's a bigger issue here - this sort of thing will
keep happening if you're running with older compilers and it's also
going to be prevent the addition of any coverage that's specific to
architectures.  It would seem better to fix this by warning only and not
erroring out, perhaps splitting the config fragments into must succeed
and can be dropped sections.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)