[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250530135800.13437-1-kuba@kernel.org>
Date: Fri, 30 May 2025 06:58:00 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: davem@...emloft.net
Cc: netdev@...r.kernel.org,
Jakub Kicinski <kuba@...nel.org>,
brendan.higgins@...ux.dev,
davidgow@...gle.com,
rmoar@...gle.com,
broonie@...nel.org,
rf@...nsource.cirrus.com,
mic@...ikod.net,
skhan@...uxfoundation.org,
linux-kselftest@...r.kernel.org,
kunit-dev@...glegroups.com
Subject: [PATCH net] Revert "kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests"
This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.
The commit in question breaks kunit for older compilers:
$ gcc --version
gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
$ ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64
Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=x86_64 O=.kunit olddefconfig
ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config.
This is probably due to unsatisfied dependencies.
Missing: CONFIG_INIT_STACK_ALL_PATTERN=y
Link: https://lore.kernel.org/20250529083811.778bc31b@kernel.org
Fixes: a571a9a1b120 ("kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests")
Signed-off-by: Jakub Kicinski <kuba@...nel.org>
---
I'd like to take this in via netdev since it fixes our CI.
We'll send it to Linus next week.
CC: brendan.higgins@...ux.dev
CC: davidgow@...gle.com
CC: rmoar@...gle.com
CC: broonie@...nel.org
CC: rf@...nsource.cirrus.com
CC: mic@...ikod.net
CC: skhan@...uxfoundation.org
CC: linux-kselftest@...r.kernel.org
CC: kunit-dev@...glegroups.com
---
tools/testing/kunit/configs/all_tests.config | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
index 48b132cd9d2a..2f093048d985 100644
--- a/tools/testing/kunit/configs/all_tests.config
+++ b/tools/testing/kunit/configs/all_tests.config
@@ -10,7 +10,6 @@ CONFIG_KUNIT_EXAMPLE_TEST=y
CONFIG_KUNIT_ALL_TESTS=y
CONFIG_FORTIFY_SOURCE=y
-CONFIG_INIT_STACK_ALL_PATTERN=y
CONFIG_IIO=y
--
2.49.0
Powered by blists - more mailing lists