netdev - RE: [Intel-wired-lan] [PATCH iwl-next v2 1/2] net: intel: rename 'hena' to 'hashcfg' for clarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6241346475B29A59D4FDA6638B61A@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Fri, 30 May 2025 06:52:33 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, Intel Wired LAN
	<intel-wired-lan@...ts.osuosl.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, netdev <netdev@...r.kernel.org>
CC: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, Simon Horman <horms@...nel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v2 1/2] net: intel: rename
 'hena' to 'hashcfg' for clarity

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Jacob Keller
> Sent: 06 May 2025 01:44
> To: Intel Wired LAN <intel-wired-lan@...ts.osuosl.org>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; netdev <netdev@...r.kernel.org>
> Cc: Keller, Jacob E <jacob.e.keller@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Simon Horman <horms@...nel.org>
> Subject: [Intel-wired-lan] [PATCH iwl-next v2 1/2] net: intel: rename 'hena' to 'hashcfg' for clarity
>
> i40e, ice, and iAVF all use 'hena' as a shorthand for the "hash enable"
configuration. This comes originally from the X710 datasheet 'xxQF_HENA'
registers. In the context of the registers the meaning is fairly clear.
>
> However, on its own, hena is a weird name that can be more difficult to understand. This is especially true in ice. The E810 hardware doesn't even have registers with HENA in the name.
>
> Replace the shorthand 'hena' with 'hashcfg'. This makes it clear the variables deal with the Hash configuration, not just a single boolean on/off for all hashing.
>
> Do not update the register names. These come directly from the datasheet for X710 and X722, and it is more important that the names can be searched.
>
> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_txrx.h        |  8 ++--
> drivers/net/ethernet/intel/iavf/iavf.h             | 10 ++---
> drivers/net/ethernet/intel/iavf/iavf_txrx.h        |  4 +-
> drivers/net/ethernet/intel/ice/ice_flow.h          |  4 +-
> drivers/net/ethernet/intel/ice/ice_virtchnl.h      |  4 +-
> include/linux/avf/virtchnl.h                       | 22 +++++------
> drivers/net/ethernet/intel/i40e/i40e_main.c        |  2 +-
> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 46 +++++++++++-----------
> drivers/net/ethernet/intel/iavf/iavf_main.c        | 17 ++++----
> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c    | 33 ++++++++--------
> drivers/net/ethernet/intel/ice/ice_lib.c           |  2 +-
> drivers/net/ethernet/intel/ice/ice_virtchnl.c      | 44 ++++++++++-----------
> .../ethernet/intel/ice/ice_virtchnl_allowlist.c    |  2 +-
> 13 files changed, 101 insertions(+), 97 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)