netdev - Re: [PATCH] xdp: Remove unused mem_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <696364e6-5eb1-4543-b9f4-60fba10623fc@kernel.org>
Date: Fri, 30 May 2025 08:51:12 +0200
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>, LKML
 <linux-kernel@...r.kernel.org>,
 Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
 netdev <netdev@...r.kernel.org>, bpf@...r.kernel.org
Cc: Jonathan Lemon <jonathan.lemon@...il.com>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>
Subject: Re: [PATCH] xdp: Remove unused mem_return_failed event



On 29/05/2025 22.05, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
> 
> The change to allow page_poll to handle its own page destruction instead
                            ^^^^
You miss-spelled page_pool as "page_poll"

> of relying on XDP removed the trace_mem_return_failed() tracepoint caller,
> but did not remove the mem_return_failed trace event. As trace events take
> up memory when they are created regardless of if they are used or not,
> having this unused event around wastes around 5K of memory.
> 
> Remove the unused event.
> 
> Link: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.home/
> 
> Fixes: c3f812cea0d7 ("page_pool: do not release pool until inflight == 0.")
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
>   include/trace/events/xdp.h | 26 --------------------------
>   1 file changed, 26 deletions(-)

With above spelling fixed:

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>


> diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
> index a7e5452b5d21..d3ef86c97ae3 100644
> --- a/include/trace/events/xdp.h
> +++ b/include/trace/events/xdp.h
> @@ -379,32 +379,6 @@ TRACE_EVENT(mem_connect,
>   	)
>   );
>   
> -TRACE_EVENT(mem_return_failed,
> -
> -	TP_PROTO(const struct xdp_mem_info *mem,
> -		 const struct page *page),
> -
> -	TP_ARGS(mem, page),
> -
> -	TP_STRUCT__entry(
> -		__field(const struct page *,	page)
> -		__field(u32,		mem_id)
> -		__field(u32,		mem_type)
> -	),
> -
> -	TP_fast_assign(
> -		__entry->page		= page;
> -		__entry->mem_id		= mem->id;
> -		__entry->mem_type	= mem->type;
> -	),
> -
> -	TP_printk("mem_id=%d mem_type=%s page=%p",
> -		  __entry->mem_id,
> -		  __print_symbolic(__entry->mem_type, __MEM_TYPE_SYM_TAB),
> -		  __entry->page
> -	)
> -);
> -
>   TRACE_EVENT(bpf_xdp_link_attach_failed,
>   
>   	TP_PROTO(const char *msg),