netdev - Re: [PATCH] xdp: Remove unused mem_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250530121638.35106c15@gandalf.local.home>
Date: Fri, 30 May 2025 12:16:38 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Jesper Dangaard Brouer <hawk@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux Trace Kernel
 <linux-trace-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org>,
 bpf@...r.kernel.org, Jonathan Lemon <jonathan.lemon@...il.com>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Masami Hiramatsu
 <mhiramat@...nel.org>, Ilias Apalodimas <ilias.apalodimas@...aro.org>
Subject: Re: [PATCH] xdp: Remove unused mem_return_failed event

On Fri, 30 May 2025 08:51:12 +0200
Jesper Dangaard Brouer <hawk@...nel.org> wrote:

> > The change to allow page_poll to handle its own page destruction instead  
>                             ^^^^
> You miss-spelled page_pool as "page_poll"

Oops!

> 
> > of relying on XDP removed the trace_mem_return_failed() tracepoint caller,
> > but did not remove the mem_return_failed trace event. As trace events take
> > up memory when they are created regardless of if they are used or not,
> > having this unused event around wastes around 5K of memory.
> > 
> > Remove the unused event.
> > 
> > Link: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.home/
> > 
> > Fixes: c3f812cea0d7 ("page_pool: do not release pool until inflight == 0.")
> > Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> > ---
> >   include/trace/events/xdp.h | 26 --------------------------
> >   1 file changed, 26 deletions(-)  
> 
> With above spelling fixed:
> 
> Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>

Thanks. Will this go through the networking tree or should I just take it?

-- Steve