netdev - Re: [PATCH ethtool 0/2] module_common: adjust the JSON output for per-lane signals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tby3ld5penbfzrpvlbocwrmnyyahtjrocejelqfhfcrryz3uzq@24fixhzgipcl>
Date: Fri, 30 May 2025 13:35:25 +0200
From: Michal Kubecek <mkubecek@...e.cz>
To: Jakub Kicinski <kuba@...nel.org>
Cc: danieller@...dia.com, idosch@...sch.org, netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 0/2] module_common: adjust the JSON output for
 per-lane signals

On Thu, May 29, 2025 at 07:20:31AM GMT, Jakub Kicinski wrote:
> I got some feedback from users trying to integrate the SFP JSON
> output to Meta's monitoring systems. The loss / fault signals
> are currently a bit awkward to parse. This patch set changes
> the format, is it still okay to merge it (as a fix?)
> I think it's a worthwhile improvement, not sure how many people
> depend on the current JSON format after 1 release..

It's unfortunate that the format already got into 6.14 but thankfully
it's been only about six weeks since so hopefully there won't be many
(or perhaps none if we are lucky).

I wonder if it would make sense to also release 6.14.1 with the format
change to make it more apparent for those using 6.14 that the change
should be backported. SLE16 (and Leap 16.0) is going to be one of the
distributions with ethtool 6.14 but there I can add the patch myself.

Michal

> 
> Jakub Kicinski (2):
>   module_common: always print per-lane status in JSON
>   module_common: print loss / fault signals as bool
> 
>  module-common.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> -- 
> 2.49.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)