netdev - RE: [PATCH net] net: enetc: fix wrong TPID registers and remove dead branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510044810B2C0973978B6248860A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Sat, 31 May 2025 01:27:15 +0000
From: Wei Fang <wei.fang@....com>
To: Vladimir Oltean <vladimir.oltean@....com>
CC: Claudiu Manoil <claudiu.manoil@....com>, Clark Wang
	<xiaoning.wang@....com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH net] net: enetc: fix wrong TPID registers and remove dead
 branch

> > In addition, since ENETC_RXBD_FLAG_TPID is defined as GENMASK(1, 0),
> > the possible values are only 0, 1, 2, 3, so the default branch will
> > never be true, so remove the default branch.
> >
> > Fixes: 827b6fd04651 ("net: enetc: fix incorrect TPID when receiving 802.1ad
> tagged packets")
> > Signed-off-by: Wei Fang <wei.fang@....com>
> 
> I see what the patch is trying to do, but how did you test/reproduce this?
> The CVLANR1/CVLANR2 registers are by default zero, and the driver
> doesn't write them, so I guess custom TPID values are never recognized
> in net-next. In such situations, I believe fixing a bug that has no
> consequences should also be considered net-next material (and net-next
> is currently closed until June 8th).
> 

This issue cannot be reproduced because, as you said, the current
driver does not support custom TPID, so the issue will not be triggered
in actual use. However, from the perspective of code and combined
with hardware, this is problematic.

I agree with you, because it does not fix the issue in actual use, this
patch can also be submitted to the net-next tree as an optimization.