netdev - Re: [PATCH] gve: add missing NULL check for gve_alloc_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANH7hM5O7aq=bMybUqgMf5MxgAZm29RvCTO_oSOfAn1efZnKhg@mail.gmail.com>
Date: Mon, 2 Jun 2025 12:24:55 -0700
From: Bailey Forrest <bcf@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: ALOK TIWARI <alok.a.tiwari@...cle.com>, Mina Almasry <almasrymina@...gle.com>, 
	joshwash@...gle.com, willemb@...gle.com, pkaligineedi@...gle.com, 
	pabeni@...hat.com, kuba@...nel.org, jeroendb@...gle.com, 
	hramamurthy@...gle.com, andrew+netdev@...n.ch, davem@...emloft.net, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, darren.kenny@...cle.com
Subject: Re: [PATCH] gve: add missing NULL check for gve_alloc_pending_packet()
 in TX DQO

Hi Alok,

I think this patch isn't needed. gve_tx_add_skb_dqo() is only called
after checking gve_maybe_stop_tx_dqo(), which checks that
gve_alloc_pending_packet() will not return NULL.