netdev - Re: [PATCH 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <602cc521-9b7e-424b-8956-429d654fc760@gmx.net>
Date: Mon, 2 Jun 2025 21:28:02 +0200
From: Stefan Wahren <wahrenst@....net>
To: Frank Li <Frank.li@....com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
 imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format

Hi Frank,

Am 02.06.25 um 17:35 schrieb Frank Li:
> On Fri, May 30, 2025 at 10:33:28AM +0200, Stefan Wahren wrote:
>> Hi Frank,
>>
>> thanks for this patch.
>>
>> Am 29.05.25 um 21:17 schrieb Frank Li:
...
>>> +  - Frank Li <Frank.Li@....com>
>>> +
>>> +description: |
>>> +  The QCA7000 is a serial-to-powerline bridge with a host interface which could
>>> +  be configured either as SPI or UART slave. This configuration is done by
>>> +  the QCA7000 firmware.
>>> +
>>> +  (a) Ethernet over SPI
>>> +
>>> +  In order to use the QCA7000 as SPI device it must be defined as a child of a
>>> +  SPI master in the device tree.
>> Could you please add the dropped "(b) Ethernet over UART" description here?
> Okay, I will add back.
>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: qca,qca7000
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  spi-cpha: true
>>> +
>>> +  spi-cpol: true
>> In case of a SPI setup these properties should be required. Unfortunately
>> i'm not sure how to enforce this. Maybe depending on the presence of "reg"?
> But It think depend on reg is not good idea, which too obscure.
I understand, but this was the first idea which comes to my mind.
>   Ideally it
> should be use two compatible strings. It should treat as two kinds device.
Back in the days there was a discussion about different compatible 
strings and it was rejected [1].
> It is really old devices and not worth to update compatible string.
Yes, this powerline communication chip was introduced in 2012 but it's 
very widespread. Most of the electric vehicles and DC charging stations 
use this chip.

Regards

[1] - https://lkml.org/lkml/2017/5/19/390
>
> Maybe some one in dt team can provide suggestion!
>
> Rob and Krzysztof Kozlowski:
>    any idea about this?
>
> Frank