netdev - Re: [PATCH net-next v2 0/4] netconsole: Optimize console registration and improve testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250602075747.5e659655@kernel.org>
Date: Mon, 2 Jun 2025 07:57:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Tejun Heo <tj@...nel.org>, Andrew Morton
 <akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>,
 horms@...nel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 gustavold@...il.com, Usama Arif <usamaarif642@...il.com>,
 linux-kselftest@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net-next v2 0/4] netconsole: Optimize console
 registration and improve testing

On Mon, 02 Jun 2025 03:34:40 -0700 Breno Leitao wrote:
> During performance analysis of console subsystem latency, I discovered that
> netconsole registers console handlers even when no active targets exist.
> These orphaned console handlers are invoked on every printk() call, get
> the lock, iterate through empty target lists, and consume CPU cycles
> without performing any useful work.
> 
> This patch series addresses the inefficiency by:
> 
> 1. Implementing dynamic console registration/unregistration based on target
>    availability, ensuring console handlers are only active when needed
> 2. Adding automatic cleanup of unused console registrations when targets
>    are disabled or removed
> 3. Extending the selftest suite to cover non-extended console format,
>    which was previously untested
> 
> The optimization reduces printk() overhead by eliminating unnecessary
> function calls and list traversals when netconsole targets are not
> configured, improving overall system performance during heavy logging
> scenarios.

Ah, I wasn't very clear, full form letter at the end.

But also the tests seem to have failed now:
https://netdev.bots.linux.dev/contest.html?branch=net-next-2025-06-02--12-00&executor=vmksft-net-drv&pw-n=0&pass=0

## Form letter - net-next-closed

Linus has already merged our PR with features for v6.16.
net-next is closed for new drivers, features, code refactoring and
optimizations for the remained for the merge window.

Please repost when net-next reopens after June 9th.

RFC patches sent for review only are obviously welcome at any time.

See:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
-- 
pw-bot: defer
pv-bot: closed