netdev - [PATCH iproute2-next] Parse FQ band weights correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1748922042-32491-1-git-send-email-vmalla@linux.microsoft.com>
Date: Mon,  2 Jun 2025 20:40:42 -0700
From: vmalla@...ux.microsoft.com
To: netdev@...r.kernel.org
Cc: dsahern@...il.com,
	stephen@...workplumber.org,
	edumazet@...gle.com,
	vmalla@...rosoft.com
Subject: [PATCH iproute2-next] Parse FQ band weights correctly

From: Hemanth Malla <vmalla@...rosoft.com>

Currently, NEXT_ARG() is called twice resulting in the first
weight being skipped. This results in the following errors:

$ sudo tc qdisc replace dev enP64183s1 root fq weights 589824 196608 65536
Not enough elements in weights

$ sudo tc qdisc replace dev enP64183s1 root fq weights 589824 196608 65536 nopacing
Illegal "weights" element, positive number expected

Fixes: 567eb4e41045 ("tc: fq: add TCA_FQ_WEIGHTS handling")
Signed-off-by: Hemanth Malla <vmalla@...rosoft.com>
---
 tc/q_fq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tc/q_fq.c b/tc/q_fq.c
index 51a43122..13c5a896 100644
--- a/tc/q_fq.c
+++ b/tc/q_fq.c
@@ -258,7 +258,6 @@ static int fq_parse_opt(const struct qdisc_util *qu, int argc, char **argv,
                                fprintf(stderr, "Duplicate \"weights\"\n");
                                return -1;
                        }
-                       NEXT_ARG();
                        for (idx = 0; idx < FQ_BANDS; ++idx) {
                                int val;

--
2.43.0