netdev - Re: [PATCH iproute2-next] Parse FQ band weights correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iJW7oSi3NzAyJpTVD1==1Ms0OOerLtif75=jnYF1rcNXg@mail.gmail.com>
Date: Mon, 2 Jun 2025 23:25:11 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: vmalla@...ux.microsoft.com
Cc: netdev@...r.kernel.org, dsahern@...il.com, stephen@...workplumber.org, 
	vmalla@...rosoft.com
Subject: Re: [PATCH iproute2-next] Parse FQ band weights correctly

On Mon, Jun 2, 2025 at 8:41 PM <vmalla@...ux.microsoft.com> wrote:
>
> From: Hemanth Malla <vmalla@...rosoft.com>
>
> Currently, NEXT_ARG() is called twice resulting in the first
> weight being skipped. This results in the following errors:
>
> $ sudo tc qdisc replace dev enP64183s1 root fq weights 589824 196608 65536
> Not enough elements in weights
>
> $ sudo tc qdisc replace dev enP64183s1 root fq weights 589824 196608 65536 nopacing
> Illegal "weights" element, positive number expected
>
> Fixes: 567eb4e41045 ("tc: fq: add TCA_FQ_WEIGHTS handling")
> Signed-off-by: Hemanth Malla <vmalla@...rosoft.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>