netdev - Re: [RFC PATCH net-next 1/2] dt-bindings: net: pse-pd: Describe the LTC4266 PSE chipset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250604110654.52dd736b@kmaincent-XPS-13-7390>
Date: Wed, 4 Jun 2025 11:06:54 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Kyle Swenson <kyle.swenson@....tech>
Cc: "o.rempel@...gutronix.de" <o.rempel@...gutronix.de>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
 <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
 <conor+dt@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 1/2] dt-bindings: net: pse-pd: Describe the
 LTC4266 PSE chipset

Le Tue, 3 Jun 2025 23:04:37 +0000,
Kyle Swenson <kyle.swenson@....tech> a écrit :

> Add the LTC4266 PSE controller from Linear Technology to the device-tree
> bindings.

Hello Kyle,

Nice to see your patch!

Your Sign-off-by tag is missing on all your patches.

> ---
>  .../bindings/net/pse-pd/lltc,ltc4266.yaml     | 146 ++++++++++++++++++
>  1 file changed, 146 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/net/pse-pd/lltc,ltc4266.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/pse-pd/lltc,ltc4266.yaml
> b/Documentation/devicetree/bindings/net/pse-pd/lltc,ltc4266.yaml new file
> mode 100644 index 000000000000..874447ab6c84
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/pse-pd/lltc,ltc4266.yaml
> @@ -0,0 +1,146 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/pse-pd/lltc,ltc4266.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LTC LTC4266 Power Sourcing Equipment controller
> +
> +maintainers:
> +  - Kyle Swenson <kyle.swenson@....tech>
> +
> +allOf:
> +  - $ref: pse-controller.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - lltc,ltc4266
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#pse-cells':
> +    const: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  channels:
> +
> +    description: This parameter describes the mapping between the logical
> ports
> +      on the PSE controller and the physical ports.

The channels parameter is not describing the mapping but only the channels
list. I also have to change the tps23881 binding doc similarly.
We discussed about this here
https://lore.kernel.org/netdev/20250517003525.2f6a5005@kmaincent-XPS-13-7390/

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com