[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aEBd4SMbfFOx4YHE@p620>
Date: Wed, 4 Jun 2025 14:53:36 +0000
From: Kyle Swenson <kyle.swenson@....tech>
To: Kory Maincent <kory.maincent@...tlin.com>
CC: "o.rempel@...gutronix.de" <o.rempel@...gutronix.de>,
"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 1/2] dt-bindings: net: pse-pd: Describe the
LTC4266 PSE chipset
On Wed, Jun 04, 2025 at 11:06:54AM +0200, Kory Maincent wrote:
> Le Tue, 3 Jun 2025 23:04:37 +0000,
> Kyle Swenson <kyle.swenson@....tech> a écrit :
>
> Hello Kyle,
>
> Nice to see your patch!
Thanks! A bit later than I had intended but late is better than never I
guess.
>
> Your Sign-off-by tag is missing on all your patches.
My mistake. I had intended to add that but evidently didn't.
> > + channels:
> > +
> > + description: This parameter describes the mapping between the logical
> > ports
> > + on the PSE controller and the physical ports.
>
> The channels parameter is not describing the mapping but only the channels
> list. I also have to change the tps23881 binding doc similarly.
> We discussed about this here
> https://lore.kernel.org/netdev/20250517003525.2f6a5005@kmaincent-XPS-13-7390/
Oh, thanks for the link. I'll fix this (and all the other issues in the
binding) in v2.
Thanks,
Kyle
Powered by blists - more mailing lists