[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87a56hf1ks.fsf@nvidia.com>
Date: Mon, 9 Jun 2025 16:10:07 +0200
From: Petr Machata <petrm@...dia.com>
To: Ido Schimmel <idosch@...dia.com>
CC: Petr Machata <petrm@...dia.com>, David Ahern <dsahern@...il.com>,
<netdev@...r.kernel.org>, Nikolay Aleksandrov <razor@...ckwall.org>
Subject: Re: [PATCH iproute2-next 1/4] ip: ipstats: Iterate all xstats
attributes
Ido Schimmel <idosch@...dia.com> writes:
> On Fri, Jun 06, 2025 at 05:04:50PM +0200, Petr Machata wrote:
>> @@ -600,15 +601,14 @@ int ipstats_stat_desc_show_xstats(struct ipstats_stat_show_attrs *attrs,
>> if (at == NULL)
>> return err;
>>
>> - tb = alloca(sizeof(*tb) * (xdesc->inner_max + 1));
>> - err = parse_rtattr_nested(tb, xdesc->inner_max, at);
>> - if (err != 0)
>> - return err;
>> -
>> - if (tb[xdesc->inner_at] != NULL) {
>> - print_nl();
>> - xdesc->show_cb(tb[xdesc->inner_at]);
>> + rem = RTA_PAYLOAD(at);
>> + for (i = RTA_DATA(at); RTA_OK(i, rem); i = RTA_NEXT(i, rem)) {
>
> Use rtattr_for_each_nested() ?
Better.
Powered by blists - more mailing lists