netdev - Re: [PATCH iproute2-next 4/4] ip: iplink_bridge: Support bridge VLAN stats in `ip stats'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xh5f02n.fsf@nvidia.com>
Date: Mon, 9 Jun 2025 16:10:50 +0200
From: Petr Machata <petrm@...dia.com>
To: Ido Schimmel <idosch@...dia.com>
CC: Petr Machata <petrm@...dia.com>, David Ahern <dsahern@...il.com>,
	<netdev@...r.kernel.org>, Nikolay Aleksandrov <razor@...ckwall.org>
Subject: Re: [PATCH iproute2-next 4/4] ip: iplink_bridge: Support bridge
 VLAN stats in `ip stats'


Ido Schimmel <idosch@...dia.com> writes:

> On Fri, Jun 06, 2025 at 05:04:53PM +0200, Petr Machata wrote:
>> +static const struct ipstats_stat_desc_xstats
>> +ipstats_stat_desc_xstats_slave_bridge_vlan = {
>> +	.desc = {
>> +		.name = "vlan",
>> +		.kind = IPSTATS_STAT_DESC_KIND_LEAF,
>> +		.show = &bridge_stat_desc_show_xstats,
>> +		.pack = &ipstats_stat_desc_pack_xstats,
>> +	},
>> +	.xstats_at = IFLA_STATS_LINK_XSTATS_SLAVE,
>
> This will only show VLAN stats for bridge ports, but they also exist for
> the bridge itself inside the IFLA_STATS_LINK_XSTATS nest

I got confused by bridge -s vlan show dev br1 not actually showing
anything for VLAN-aware bridges. Seems like the corresponding data is
not even arriving from the kernel. Anyway, when I add an entry for
XSTATS (sans SLAVE) to ipstats it does actually work.