netdev - Re: [RFC net-next 4/6] eth: bnxt: support RSS on IPv6 Flow Label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLimwEPmYSf5ZAKxTPuhKmO_Dd9PwO2+01M8Gp-LkEWcS4Q@mail.gmail.com>
Date: Mon, 9 Jun 2025 16:03:48 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: pavan.chebbi@...adcom.com, willemdebruijn.kernel@...il.com, 
	netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org
Subject: Re: [RFC net-next 4/6] eth: bnxt: support RSS on IPv6 Flow Label

On Mon, Jun 9, 2025 at 11:44 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Ah, sorry, something like this?
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> index fd9405cadad1..4385a94d4d1e 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> @@ -1582,9 +1582,14 @@ static u64 get_ethtool_ipv4_rss(struct bnxt *bp)
>
>  static u64 get_ethtool_ipv6_rss(struct bnxt *bp)
>  {
> +       u64 rss = 0;
> +
>         if (bp->rss_hash_cfg & VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6)
> -               return RXH_IP_SRC | RXH_IP_DST;
> -       return 0;
> +               rss |= RXH_IP_SRC | RXH_IP_DST;
> +       if (bp->rss_hash_cfg & VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6_FLOW_LABEL)
> +               rss |= RXH_IP6_FL;
> +
> +       return rss;
>  }

Yes, I think this should work.

>
>  static int bnxt_grxfh(struct bnxt *bp, struct ethtool_rxnfc *cmd)
>
> Would someone at Broadcom be able to test (per cover letter)?
> I'd love to have the test validated on bnxt if possible :(

Yes, we'll get this tested in our lab.

> I can post a v2 with the snippet merged in if that helps.

You don't need to post v2 just for this, unless you have some other
changes you want to make.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4196 bytes)