netdev - Re: [PATCH] mac802154_hwsim: allow users to specify the number of simulated radios dynamically instead of the previously hardcoded value of 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK-6q+g3ns4BvZhgtzH6a6gDrEGpPmpugQki86fmbKxgHi51Aw@mail.gmail.com>
Date: Mon, 9 Jun 2025 19:04:08 -0400
From: Alexander Aring <aahringo@...hat.com>
To: Ramon Fontes <ramonreisfontes@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	linux-wpan@...r.kernel.org, alex.aring@...il.com, miquel.raynal@...tlin.com, 
	netdev@...r.kernel.org
Subject: Re: [PATCH] mac802154_hwsim: allow users to specify the number of
 simulated radios dynamically instead of the previously hardcoded value of 2

Hi,

On Mon, Jun 9, 2025 at 5:47 AM Ramon Fontes <ramonreisfontes@...il.com> wrote:
>
> Add a module parameter radios to allow users to configure the number
> of virtual radios created by mac802154_hwsim at module load time.
> This replaces the previously hardcoded value of 2.
>
> * Added a new module parameter radios
> * Modified the loop in hwsim_probe()
> * Updated log message in hwsim_probe()
>
> Signed-off-by: Ramon Fontes <ramonreisfontes@...il.com>
> ---
>  drivers/net/ieee802154/mac802154_hwsim.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
> index 1cab20b5a..1740abe1a 100644
> --- a/drivers/net/ieee802154/mac802154_hwsim.c
> +++ b/drivers/net/ieee802154/mac802154_hwsim.c
> @@ -27,6 +27,10 @@
>  MODULE_DESCRIPTION("Software simulator of IEEE 802.15.4 radio(s) for mac802154");
>  MODULE_LICENSE("GPL");
>
> +static unsigned int radios = 2;
> +module_param(radios, int, 0444);

uint? I can swear I saw that in an earlier patch.

> +MODULE_PARM_DESC(radios, "Number of simulated radios");
> +
>  static LIST_HEAD(hwsim_phys);
>  static DEFINE_MUTEX(hwsim_phys_lock);
>
> @@ -1018,13 +1022,13 @@ static int hwsim_probe(struct platform_device *pdev)
>         struct hwsim_phy *phy, *tmp;
>         int err, i;
>
> -       for (i = 0; i < 2; i++) {
> +       for (i = 0; i < radios; i++) {

The iterator needs to be unsigned now?

- Alex