lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <SJ1PR11MB62978A457788658845C59ADB9B6AA@SJ1PR11MB6297.namprd11.prod.outlook.com> Date: Tue, 10 Jun 2025 21:51:07 +0000 From: "Salin, Samuel" <samuel.salin@...el.com> To: "Zaremba, Larysa" <larysa.zaremba@...el.com>, "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com> CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "Jiri Pirko" <jiri@...nulli.us>, "Nikolova, Tatyana E" <tatyana.e.nikolova@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "Lobakin, Aleksander" <aleksander.lobakin@...el.com>, Michael Ellerman <mpe@...erman.id.au>, "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>, Lee Trager <lee@...ger.us>, Madhavan Srinivasan <maddy@...ux.ibm.com>, "Zaremba, Larysa" <larysa.zaremba@...el.com>, "Samudrala, Sridhar" <sridhar.samudrala@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>, Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>, "Polchlopek, Mateusz" <mateusz.polchlopek@...el.com>, "Zaki, Ahmed" <ahmed.zaki@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Karlsson, Magnus" <magnus.karlsson@...el.com>, "Tantilov, Emil S" <emil.s.tantilov@...el.com>, "Chittim, Madhu" <madhu.chittim@...el.com>, "Hay, Joshua A" <joshua.a.hay@...el.com>, "Olech, Milena" <milena.olech@...el.com>, "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>, "Singhai, Anjali" <anjali.singhai@...el.com>, "Kubiak, Michal" <michal.kubiak@...el.com> Subject: RE: [Intel-wired-lan] [PATCH iwl-next v4 09/15] idpf: refactor idpf to use libie control queues > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of > Larysa Zaremba > Sent: Friday, May 16, 2025 7:58 AM > To: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L > <anthony.l.nguyen@...el.com> > Cc: David S. Miller <davem@...emloft.net>; Eric Dumazet > <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni > <pabeni@...hat.com>; Simon Horman <horms@...nel.org>; Jonathan > Corbet <corbet@....net>; Kitszel, Przemyslaw > <przemyslaw.kitszel@...el.com>; Jiri Pirko <jiri@...nulli.us>; Nikolova, Tatyana > E <tatyana.e.nikolova@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>; > Lobakin, Aleksander <aleksander.lobakin@...el.com>; Michael Ellerman > <mpe@...erman.id.au>; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; > Lee Trager <lee@...ger.us>; Madhavan Srinivasan <maddy@...ux.ibm.com>; > Zaremba, Larysa <larysa.zaremba@...el.com>; Samudrala, Sridhar > <sridhar.samudrala@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>; > Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>; Polchlopek, > Mateusz <mateusz.polchlopek@...el.com>; Zaki, Ahmed > <ahmed.zaki@...el.com>; netdev@...r.kernel.org; linux- > doc@...r.kernel.org; linux-kernel@...r.kernel.org; Karlsson, Magnus > <magnus.karlsson@...el.com>; Tantilov, Emil S <emil.s.tantilov@...el.com>; > Chittim, Madhu <madhu.chittim@...el.com>; Hay, Joshua A > <joshua.a.hay@...el.com>; Olech, Milena <milena.olech@...el.com>; Linga, > Pavan Kumar <pavan.kumar.linga@...el.com>; Singhai, Anjali > <anjali.singhai@...el.com>; Kubiak, Michal <michal.kubiak@...el.com> > Subject: [Intel-wired-lan] [PATCH iwl-next v4 09/15] idpf: refactor idpf to use > libie control queues > > From: Pavan Kumar Linga <pavan.kumar.linga@...el.com> > > Support to initialize and configure controlqs, and manage their > transactions was introduced in libie. As part of it, most of the existing > controlq structures are renamed and modified. Use those APIs in idpf and > make all the necessary changes. > > Previously for the send and receive virtchnl messages, there used to be a > memcpy involved in controlq code to copy the buffer info passed by the send > function into the controlq specific buffers. There was no restriction to > use automatic memory in that case. The new implementation in libie removed > copying of the send buffer info and introduced DMA mapping of the send > buffer itself. To accommodate it, use dynamic memory for the larger send > buffers. For smaller ones (<= 128 bytes) libie still can copy them into the > pre-allocated message memory. > > In case of receive, idpf receives a page pool buffer allocated by the libie > and care should be taken to release it after use in the idpf. > > The changes are fairly trivial and localized, with a notable exception > being the consolidation of idpf_vc_xn_shutdown and idpf_deinit_dflt_mbx > under the latter name. This has some additional consequences that are > addressed in the following patches. > > This refactoring introduces roughly additional 40KB of module storage used > for systems that only run idpf, so idpf + libie_cp + libie_pci takes about > 7% more storage than just idpf before refactoring. > > We now pre-allocate small TX buffers, so that does increase the memory > usage, but reduces the need to allocate. This results in additional 256 * > 128B of memory permanently used, increasing the worst-case memory usage > by > 32KB but our ctlq RX buffers need to be of size 4096B anyway (not changed > by the patchset), so this is hardly noticeable. > > As for the timings, the fact that we are mostly limited by the HW response > time which is far from instant, is not changed by this refactor. > > Reviewed-by: Michal Kubiak <michal.kubiak@...el.com> > Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com> > Co-developed-by: Larysa Zaremba <larysa.zaremba@...el.com> > Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com> > --- > 2.47.0 Tested-by: Samuel Salin <Samuel.salin@...el.com>
Powered by blists - more mailing lists