netdev - RE: [Intel-wired-lan] [PATCH iwl-next v4 10/15] idpf: make mbx_task queueing and cancelling more consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB62976C256190FA1A2DA3EA7A9B6AA@SJ1PR11MB6297.namprd11.prod.outlook.com>
Date: Tue, 10 Jun 2025 21:51:09 +0000
From: "Salin, Samuel" <samuel.salin@...el.com>
To: "Zaremba, Larysa" <larysa.zaremba@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jonathan Corbet
	<corbet@....net>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "Jiri
 Pirko" <jiri@...nulli.us>, "Nikolova, Tatyana E"
	<tatyana.e.nikolova@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"Lobakin, Aleksander" <aleksander.lobakin@...el.com>, Michael Ellerman
	<mpe@...erman.id.au>, "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
	Lee Trager <lee@...ger.us>, Madhavan Srinivasan <maddy@...ux.ibm.com>,
	"Zaremba, Larysa" <larysa.zaremba@...el.com>, "Samudrala, Sridhar"
	<sridhar.samudrala@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>, "Polchlopek,
 Mateusz" <mateusz.polchlopek@...el.com>, "Zaki, Ahmed"
	<ahmed.zaki@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Karlsson,
 Magnus" <magnus.karlsson@...el.com>, "Tantilov, Emil S"
	<emil.s.tantilov@...el.com>, "Chittim, Madhu" <madhu.chittim@...el.com>,
	"Hay, Joshua A" <joshua.a.hay@...el.com>, "Olech, Milena"
	<milena.olech@...el.com>, "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>,
	"Singhai, Anjali" <anjali.singhai@...el.com>, "Kubiak, Michal"
	<michal.kubiak@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v4 10/15] idpf: make mbx_task
 queueing and cancelling more consistent



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Larysa Zaremba
> Sent: Friday, May 16, 2025 7:58 AM
> To: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>
> Cc: David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Simon Horman <horms@...nel.org>; Jonathan
> Corbet <corbet@....net>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Jiri Pirko <jiri@...nulli.us>; Nikolova, Tatyana
> E <tatyana.e.nikolova@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>;
> Lobakin, Aleksander <aleksander.lobakin@...el.com>; Michael Ellerman
> <mpe@...erman.id.au>; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>;
> Lee Trager <lee@...ger.us>; Madhavan Srinivasan <maddy@...ux.ibm.com>;
> Zaremba, Larysa <larysa.zaremba@...el.com>; Samudrala, Sridhar
> <sridhar.samudrala@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>;
> Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>; Polchlopek,
> Mateusz <mateusz.polchlopek@...el.com>; Zaki, Ahmed
> <ahmed.zaki@...el.com>; netdev@...r.kernel.org; linux-
> doc@...r.kernel.org; linux-kernel@...r.kernel.org; Karlsson, Magnus
> <magnus.karlsson@...el.com>; Tantilov, Emil S <emil.s.tantilov@...el.com>;
> Chittim, Madhu <madhu.chittim@...el.com>; Hay, Joshua A
> <joshua.a.hay@...el.com>; Olech, Milena <milena.olech@...el.com>; Linga,
> Pavan Kumar <pavan.kumar.linga@...el.com>; Singhai, Anjali
> <anjali.singhai@...el.com>; Kubiak, Michal <michal.kubiak@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v4 10/15] idpf: make mbx_task
> queueing and cancelling more consistent
> 
> As a consequence of refactoring idpf code to use libeth APIs,
> idpf_vc_xn_shutdown was merged with and replaced by
> idpf_deinit_dflt_mbx.
> This does not affect the Tx path, as it checked for a presence of an xn manager
> anyway. Rx processing is handled by the mbx_task that is not always cancelled
> before calling the new consolidated mailbox deinit function.
> Moreover, in the reset path idpf_intr_rel() reschedules it after the deinit is
> done. This leads to mbx_task referencing the freed mailbox and causing
> KASAN warnings.
> 
> To remedy this, in the init path, do the first queueing of mbx_task in
> idpf_init_dflt_mbx(), in deinit and reset, always cancel the task in
> idpf_deinit_dflt_mbx() and in every flow first call idpf_mb_intr_rel_irq().
> 
> Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
> ---
> 2.47.0

Tested-by: Samuel Salin <Samuel.salin@...el.com>