netdev - Re: [PATCH net] net: drv: netdevsim: don't napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a56dj4t6.fsf@linux.ibm.com>
Date: Wed, 11 Jun 2025 17:23:33 -0500
From: Dave Marquardt <davemarq@...ux.ibm.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
        Breno
 Leitao <leitao@...ian.org>, dw@...idwei.uk
Subject: Re: [PATCH net] net: drv: netdevsim: don't napi_complete() from
 netpoll

Jakub Kicinski <kuba@...nel.org> writes:

> netdevsim supports netpoll. Make sure we don't call napi_complete()
> from it, since it may not be scheduled. Breno reports hitting a
> warning in napi_complete_done():

I decided to go learn a bit more about netdevsim, and ran across a typo
in Documentation/networking/devlink/netdevsim.rst:

The ``netdevsim`` driver supports rate objects management, which includes:

- registerging/unregistering leaf rate objects per VF devlink port;
  ^^^^^^^^^^^^

-Dave