netdev - Re: [PATCH net] net: drv: netdevsim: don't napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEqIqDwHUGcblXjT@gmail.com>
Date: Thu, 12 Jun 2025 00:58:32 -0700
From: Breno Leitao <leitao@...ian.org>
To: Dave Marquardt <davemarq@...ux.ibm.com>
Cc: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net,
	netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
	andrew+netdev@...n.ch, horms@...nel.org, dw@...idwei.uk
Subject: Re: [PATCH net] net: drv: netdevsim: don't napi_complete() from
 netpoll

Hello Dave,

On Wed, Jun 11, 2025 at 05:23:33PM -0500, Dave Marquardt wrote:
> Jakub Kicinski <kuba@...nel.org> writes:
> 
> > netdevsim supports netpoll. Make sure we don't call napi_complete()
> > from it, since it may not be scheduled. Breno reports hitting a
> > warning in napi_complete_done():
> 
> I decided to go learn a bit more about netdevsim, and ran across a typo
> in Documentation/networking/devlink/netdevsim.rst:

I acknowledge the bug exists in the latest netnext/main repo. Would you
like to send a patch and fix it, or, should we?

Thanks for reporting it.
--breno