netdev - Re: [PATCH net-next 02/14] net: ipv4: ipmr: ipmr_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09c653e7-308f-4075-a3ba-892846e1360b@blackwall.org>
Date: Thu, 12 Jun 2025 13:28:45 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...il.com>,
 netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Ido Schimmel <idosch@...dia.com>,
 mlxsw@...dia.com
Subject: Re: [PATCH net-next 02/14] net: ipv4: ipmr: ipmr_queue_xmit(): Drop
 local variable `dev'

On 6/9/25 23:50, Petr Machata wrote:
> The variable is used for caching of rt->dst.dev. The netdevice referenced
> therein does not change during the scope of validity of that local. At the
> same time, the local is only used twice, and each of these uses will end up
> in a different function in the following patches, further eliminating any
> use the local could have had.
> 
> Drop the local altogether and inline the uses.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
>   net/ipv4/ipmr.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>