netdev - Re: [PATCH net-next 03/14] net: ipv4: ipmr: Split ipmr_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f6a736c-a8d0-4524-93fe-fde5162d76d6@blackwall.org>
Date: Thu, 12 Jun 2025 13:29:18 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...il.com>,
 netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Ido Schimmel <idosch@...dia.com>,
 mlxsw@...dia.com
Subject: Re: [PATCH net-next 03/14] net: ipv4: ipmr: Split ipmr_queue_xmit()
 in two

On 6/9/25 23:50, Petr Machata wrote:
> Some of the work of ipmr_queue_xmit() is specific to IPMR forwarding, and
> should not take place on the output path. In order to allow reuse of the
> common parts, split the function into two: the ipmr_prepare_xmit() helper
> that takes care of the common bits, and the ipmr_queue_fwd_xmit(), which
> invokes the former and encapsulates the whole forwarding algorithm.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
>   net/ipv4/ipmr.c | 45 +++++++++++++++++++++++++++++----------------
>   1 file changed, 29 insertions(+), 16 deletions(-)
> 

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>