netdev - Re: [PATCH net-next] net: stmmac: improve .set_clk_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32bf62cf-ce05-4e8f-8e3a-85b24b931fb9@intel.com>
Date: Thu, 12 Jun 2025 10:34:36 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, Andrew Lunn
	<andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
CC: Alexandre Torgue <alexandre.torgue@...s.st.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-stm32@...md-mailman.stormreply.com>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>, <netdev@...r.kernel.org>, Paolo Abeni
	<pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: stmmac: improve .set_clk_tx_rate() method
 error message



On 6/12/2025 8:21 AM, Russell King (Oracle) wrote:
> Improve the .set_clk_tx_rate() method error message to include the
> PHY interface mode along with the speed, which will be helpful to
> the RK implementations.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 1369fa70bc58..24a4b82e934b 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1062,8 +1062,8 @@ static void stmmac_mac_link_up(struct phylink_config *config,
>  						interface, speed);
>  		if (ret < 0)
>  			netdev_err(priv->dev,
> -				   "failed to configure transmit clock for %dMbps: %pe\n",
> -				   speed, ERR_PTR(ret));
> +				   "failed to configure %s transmit clock for %dMbps: %pe\n",
> +				   phy_modes(interface), speed, ERR_PTR(ret));
>  	}
>  
>  	stmmac_mac_set(priv, priv->ioaddr, true);

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>