netdev - Re: [PATCH net-next] net: phy: simplify phy_get_internal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d263e6d6-72c6-4b52-b07f-aa6dbbb7f29a@intel.com>
Date: Thu, 12 Jun 2025 10:53:25 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, Andrew Lunn
	<andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	<netdev@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: phy: simplify phy_get_internal_delay()



On 6/11/2025 6:56 AM, Russell King (Oracle) wrote:
> Simplify the arguments passed to phy_get_internal_delay() - the "dev"
> argument is always &phydev->mdio.dev, and as the phydev is passed in,
> there's no need to also pass in the struct device, especially when this
> function is the only reason for the caller to have a local "dev"
> variable.
> 
> Remove the redundant "dev" argument, and update the callers.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>