netdev - Re: [PATCH net-next v9 13/15] net: homa: create homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXJAmzwRkpjPSWyyPv-P9=rrN6u=Lc=dXOXMJMgNo0mY3Rc6A@mail.gmail.com>
Date: Fri, 13 Jun 2025 11:44:54 -0700
From: John Ousterhout <ouster@...stanford.edu>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, edumazet@...gle.com, 
	kuba@...nel.org
Subject: Re: [PATCH net-next v9 13/15] net: homa: create homa_timer.c

On Fri, Jun 13, 2025 at 7:41 AM Simon Horman <horms@...nel.org> wrote:
> > +/**
> > + * homa_timer() - This function is invoked at regular intervals ("ticks")
> > + * to implement retries and aborts for Homa.
> > + * @homa:    Overall data about the Homa protocol implementation.
> > + */
> > +void homa_timer(struct homa *homa)
> > +{
> > +     struct homa_socktab_scan scan;
> > +     struct homa_sock *hsk;
> > +     struct homa_rpc *rpc;
> > +     int total_rpcs = 0;
>
> total_rpcs is set but otherwise unused in this function.
> It looks like it can be removed.

I have fixed this now. For some reason gcc didn't flag it, even with
-Wunused-but-set-variable.

-John-