netdev - Re: [PATCH net-next v9 06/15] net: homa: create homa_sock.h and homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXJAmyP-6H5Efxn3bde+CpH5rL_Ka0J=gF=u2-VvZvv9umiCA@mail.gmail.com>
Date: Fri, 13 Jun 2025 11:47:45 -0700
From: John Ousterhout <ouster@...stanford.edu>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, edumazet@...gle.com, 
	kuba@...nel.org
Subject: Re: [PATCH net-next v9 06/15] net: homa: create homa_sock.h and homa_sock.c

On Fri, Jun 13, 2025 at 7:42 AM Simon Horman <horms@...nel.org> wrote:
>
> > +      * locks and thus may not be able to work concurently, but there are
>
> nit: concurrently

Fixed.

> > +      * enough buckets in the table to make such colllisions rare.
> > +      *
> > +      * See "Homa Locking Strategy" in homa_impl.h for more info about
> > +      * locking.
> > +      */
> > +     spinlock_t lock __context__(rpc_bucket_lock, 1, 1);
>
> As per my comment on __context__ in reply to another patch in this series.
> I am clear on the intent of using __context__ here. And it does not seem
> to be a common construct within the Kernel. I suspect it would be best
> to remove it.

See my response on patch 03/15

-John-